keenlabs / KeenClient-Python

Official Python client for the Keen IO API. Build analytics features directly into your Python apps.
https://keen.io/docs
MIT License
133 stars 58 forks source link

Cached Datasets Support #150

Closed SteadBytes closed 5 years ago

SteadBytes commented 5 years ago

What does this PR do? How does it affect users?

Adds Cached Datasets support to KeenClient. This allows users to create, read, delete and retrieve results from Cached Datasets.

How should this be tested?

Run unit tests

Try out the API live against a Keen Project (detailed examples in README)

Step through the code line by line. Things to keep in mind as you review:

Fetch the branch and/or deploy to staging to test the following:

Related tickets?

108

masojus commented 5 years ago

Thanks @SteadBytes! I can take a look at this later today or tomorrow.

masojus commented 5 years ago

At first glance, things look OK. I'll take a closer look tomorrow.

SteadBytes commented 5 years ago

Thanks for taking a look @masojus , I really appreciate it!

SteadBytes commented 5 years ago

@masojus I don't want to pressure you, but just wondering if you have had a chance to look at this yet :smile: It'd be greatly appreciated so I can make any changes if needed :+1:

SteadBytes commented 5 years ago

Thanks for merging @masojus! I was trying to follow the pattern implemented by for saved queries.

Is there any code sharing in particular that you're thinking of? It's been a while since I made the PR so I'm more than happy to PR again to clean some things up 😊

masojus commented 5 years ago

I apologize for the delay in responding, but have been busy on other projects. 😄 Some of the error handling and JSON parsing code needs tidying up, as well as the URL creation, but it's minor, and we can clean it up later. Thanks for your contributions, and any future contributions are more than welcome!

SteadBytes commented 5 years ago

No need to apologise @masojus ! 😁 Ok great, I am very happy to do the tidying up when the time comes 👍

SteadBytes commented 5 years ago

Is it possible to get an updated release onto Pypi that includes recently merged features such as this? Currently having to build from source to use this feature. Cheers :smile: