search

keenlabs / KeenClient-iOS

Official iOS client for the Keen IO API. Build analytics features directly into your iOS apps.
https://keen.io/docs
MIT License
78 stars 56 forks source link

Add Carthage support. #112

Closed zdavison closed 8 years ago

zdavison commented 9 years ago

We use Carthage @drop for iOS dependencies, so we added support for Keen.

terrhorn commented 9 years ago

Thanks for the PR @zdavison! We're not familiar with Carthage so give us some time to look it over and get back to this PR.

zdavison commented 9 years ago

Tweak it as you see fit, the only actual change is there's now a dynamic .framework target exposed in a scheme (Carthage just looks for schemes it can build and builds them, nothing more/less), which is nice to have anyways, the naming could be improved since I didn't want to conflict with your existing Keen schemes and targets.

heitortsergent commented 9 years ago

@zdavison taking a look at the PR over here :)

Just curious, is this necessary for Carthage or just for MGImageUtilities?

//! Project version number for MGImageUtilities.
FOUNDATION_EXPORT double KeenClientVersionNumber;

//! Project version string for MGImageUtilities.
FOUNDATION_EXPORT const unsigned char KeenClientVersionString[];
zdavison commented 9 years ago

Oh, that's left over from copy-paste. That is necessary to define a module (eg: @import) I believe.

heitortsergent commented 8 years ago

@zdavison thanks for the PR. I finally got around to adding Carthage support the SDK, it's working now starting from v3.5.2.

I did it from scratch because I was reading about binaries/frameworks and Bitcode these past few weeks, it ended up looking really similar to your commits. I'd love if you guys could try it out and let us know if everything is working. :)