Call upload completion block when offline

keenlabs / KeenClient-iOS

Official iOS client for the Keen IO API. Build analytics features directly into your iOS apps.

https://keen.io/docs

MIT License

78 stars 56 forks source link

Call upload completion block when offline #158

Closed heitortsergent closed 8 years ago

heitortsergent commented 8 years ago

This PR fixes #155.

It updates the uploadWithFinishedBlock to always call the passed block argument even if the user is offline, or the prepared JSON data to be sent is empty (as stated in the method description).

Also increase iOS deployment target for all targets to 7.0 to fix Xcode warnings.

coveralls commented 8 years ago

Coverage increased (+0.9%) to 60.551% when pulling b8c45f836f789e18cba776fbc172d10ed6a7aa17 on upload_completion_block into 4fbda44ddcb8a6b64e720f62ee0a03aa8a008d8b on master.

terrhorn commented 8 years ago

👍