search

keenlabs / KeenClient-iOS

Official iOS client for the Keen IO API. Build analytics features directly into your iOS apps.
https://keen.io/docs
MIT License
78 stars 56 forks source link

Fix CI error reporting. #189

Closed baumatron closed 7 years ago

baumatron commented 7 years ago

CI would mistakenly report success when xcodebuild would exit with failure, but xcpretty would not. The fix is to use set -e -o pipefail to fail when any operation in the pipe fails and exit the script with that failure code. xcpretty suggests doing this under the usage section of their readme

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 64.267% when pulling b0491e02036fe3c47b0c073aa03ed25ede489e47 on fix_ci_error_reporting into 826714a5f856f66cdb68453a5f719303fc6c12e1 on master.

baumatron commented 7 years ago

Included with #191