search

keenlabs / keen-sdk-net

A .NET SDK for the Keen IO API
MIT License
37 stars 24 forks source link

AssemblyInfo and versioning with netstandard #100

Closed masojus closed 6 years ago

masojus commented 6 years ago

Figure out how we want to handle the assembly info that is currently spread out across AssemblyInfo.cs, SharedAssemblyInfo.cs and SharedVersionInfo.cs.

New .NET Standard and .NET Core projects don't have an AssemblyInfo.cs file or a Properties virtual subfolder, so where should assembly attributes go?

https://github.com/dotnet/cli/issues/4783

masojus commented 6 years ago

We need to get this figured out fairly soon since now that we'll actually be using the netstandard2.0 DLL in manual testing, we'll be reporting incorrect version numbers via the Keen-Sdk HTTP header.

masojus commented 6 years ago

We'll likely need to add this info to the .csproj now: https://docs.microsoft.com/en-us/nuget/schema/msbuild-targets

masojus commented 6 years ago

https://stackoverflow.com/questions/42138418/equivalent-to-assemblyinfo-in-dotnet-core-csproj

masojus commented 6 years ago

This is basically done as part of the work in PRs #124, #125, and #126

roryap commented 5 years ago

In the .NET framework applications I've worked on, I have a solution-level assembly info that is shared and linked to projects in order to control versioning in a centralized place for those assemblies that need to keep their versions in step with one another.

How would this be accomplished if the assembly versions are inside the csproj files?

justintoth commented 5 years ago

You can create a Directory.Build.props file in the root of your workspace and put the common elements in there. See this SO answer.