keenlabs / keen-sdk-net

A .NET SDK for the Keen IO API
MIT License
37 stars 23 forks source link

[WIP] Port streaming event upload functionality #101

Closed Donistivanov closed 7 years ago

Donistivanov commented 7 years ago

@masojus

Everything built - is this what you expected?

From your latest comment https://github.com/keenlabs/keen-sdk-net/issues/61 I did not understand if I should wait on https://github.com/keenlabs/keen-sdk-net/issues/74 to bring in tests or if I should try and figure out how to do that.

Let me know!

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 57.453% when pulling 275ad281d678558c27236ffaa61985a2f165a95e on Donistivanov:port-streaming-event-upload-functionality into 78353036f3ddbed8b2d2b6fb21f2087caa231b50 on keenlabs:dotnetsummer.

masojus commented 7 years ago

Thanks @Donistivanov and that all just worked when running it from a test console app or something else? Did you hit the actual back end API and successfully push events to a Keen.io collection?

Yes, I'd like to get a skeleton NUnit3+Moq-based test project in soon so we can also port tests for this streaming code (and the rest) as we go. I'll make sure that happens one way or another tonight or tomorrow so you can merge/rebase to pull in that project and add the Event-related tests. In the meantime you could make sure you understand how those tests work today in the Keen.NET.Test project and maybe even code up some more tests for any places where they seem lacking, if you'd like.

We'll want to verify all the add-ons and global properties and bulk vs single events and all those details work. I'd be OK with the caching not actually working but just building, due to the potential complexities of the dependencies used by the event cache implementations...but bonus points if you want to look at Issues #62 and #65 while we get the test project in place.

Donistivanov commented 7 years ago

@masojus Yes!

image

and one of the four tried: image

Pictures for documentation. I also had to download Newtonsoft.Json for the test project.

masojus commented 7 years ago

I'm going to merge this and create an Issue to port the relevant tests.