keenlabs / keen-sdk-net

A .NET SDK for the Keen IO API
MIT License
37 stars 23 forks source link

[WIP] Port proj settings file and env #104

Closed Donistivanov closed 7 years ago

Donistivanov commented 7 years ago

This works.

It is not based off another merge request. Does not contain tests.

Looks to close #63 resolve #64

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 57.453% when pulling 9ae5c07bdb8596b981c39b655ec25513349064f6 on Donistivanov:port-proj-settings-file-and-env into 78353036f3ddbed8b2d2b6fb21f2087caa231b50 on keenlabs:dotnetsummer.

masojus commented 7 years ago

Thanks @Donistivanov! I'm hoping to take a look at this and the test project stuff, as well as the ported stream code this afternoon. Did you happen to run the Environment- and File-related code on something other than Windows (Linux, the WSL in Win10, MacOS, etc.)? It's OK if you didn't, and I'm hoping those APIs are actually portable, but if not I'll make sure to try those out on other platforms.

Donistivanov commented 7 years ago

@masojus No, I do not have other OSs

masojus commented 7 years ago

Fair enough. Thanks!