Port Most of the Query Support

keenlabs / keen-sdk-net

A .NET SDK for the Keen IO API

MIT License

37 stars 24 forks source link

Port Most of the Query Support #112

Closed masojus closed 6 years ago

masojus commented 6 years ago

This all seems to build, but I haven't tried it on MacOS or Linux.

coveralls commented 6 years ago

Coverage decreased (-0.2%) to 57.212% when pulling b0ea84c66a08677c637a4f4093693f1c4c2bf216 on jm_PortQuery_Most into 8002c5da6b9eb3d63e48337841e794c68126d567 on dotnetsummer.

coveralls commented 6 years ago

Coverage remained the same at 57.453% when pulling 3fbcb4cdc003031db471aee4c8566f0951e69e68 on jm_PortQuery_Most into 8002c5da6b9eb3d63e48337841e794c68126d567 on dotnetsummer.

masojus commented 6 years ago

This ports a bunch of Query functionality and tests. We need to exercise it manually very extensively.

masojus commented 6 years ago

BTW this brings in a ton of HTTP-related test helpers. I'm hoping we can expand on those.

Pothulapati commented 6 years ago

Looks good to me. I also tried some queries using a netcore2.0Console Application.

Sorry for making you work on this. Mine didn't work because Queries wasn't initialised. :\

Pothulapati commented 6 years ago

Awesome! Looks like all the Funnel, Multi Analysis are also Ported. What are all left to port now?

baumatron commented 6 years ago

A couple of tests are failing on MacOS, I can investigate what's going on there.

baumatron commented 6 years ago

Looks like the serialized JSON only has LF while the expected JSON has CRLF.

masojus commented 6 years ago

Did you run this on Linux too or just MacOS? I'd expect it to fail there as well. To start with we should be expecting something like Environment.NewLine in those tests, but in some of my older notes I jotted down a TODO to trim all that JSON based on a debug flag.

masojus commented 6 years ago

Alright, I rebased and squashed a few things, made a couple fixes, and we've got 117 passing tests on MacOS and Linux, and 316 passing tests across the net35, net45 and netstandard2.0 binaries on Windows. Assuming AppVeyor comes back clean I'll probably move forward with merging this.

coveralls commented 6 years ago

Coverage remained the same at 57.28% when pulling 30c1e7ee12049e062d92d3759356385c7223a1f5 on jm_PortQuery_Most into 90b6bd0d82983f069b11e3d6a5438f38d7cf7f6d on dotnetsummer.

coveralls commented 6 years ago

Coverage remained the same at 57.28% when pulling 73fd19597a3cb9bdffe6f0b05265d93adb1fd11e on jm_PortQuery_Most into 90b6bd0d82983f069b11e3d6a5438f38d7cf7f6d on dotnetsummer.