Project settings provider env tests

keenlabs / keen-sdk-net

A .NET SDK for the Keen IO API

MIT License

37 stars 23 forks source link

Project settings provider env tests #114

Closed baumatron closed 7 years ago

baumatron commented 7 years ago

Fix #108

baumatron commented 7 years ago

Do we have opinions on whether I should squash and merge or do a merge commit for this? I like to use many logical commits to make the review easier to follow, but not sure if that history is useful to keep around once the topic branch is blown away.

coveralls commented 7 years ago

Coverage remained the same at 57.453% when pulling b63b71ab30e897c4a7d5064829cdb3c8688fd144 on project_settings_provider_env_tests into 17ac44fee840a0c8a28cbca2fad96948e40bda9f on dotnetsummer.

masojus commented 7 years ago

Whatever you think is a logical/meaningful set of commits.

masojus commented 7 years ago

I'd prefer at least a merge commit, but "Squash & Merge" will actually fast forward which I'm against.

masojus commented 7 years ago

Oh and It'd be nice to merge the Travis CI change first.

baumatron commented 7 years ago

Lol. I removed some unnecessary code and added some constants so code coverage went down. Oh well.

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 57.28% when pulling 11d8af213b319cf89bc386e7830cac19a513a714 on project_settings_provider_env_tests into 17ac44fee840a0c8a28cbca2fad96948e40bda9f on dotnetsummer.

baumatron commented 7 years ago

Post merge build from my fork: https://travis-ci.org/baumatron/keen-sdk-net/builds/260398765