search

keenlabs / keen-sdk-net

A .NET SDK for the Keen IO API
MIT License
37 stars 23 forks source link

Keen SDK build problems in Azure projects #2

Closed RickRockholdMediafour closed 8 years ago

RickRockholdMediafour commented 10 years ago

I can't use the Keen.NET SDK in my Azure project, because of the SDK's dependency on Microsoft.BCL. Using this in a Visual Studio Azure project results in several warnings that can only be removed by manually editing the Azure project file (yikes), which is occasionally overwritten.

http://stackoverflow.com/questions/17180268/warning-all-projects-referencing-myproject-csproj-must-install-nuget-package-m

RobotCaleb commented 10 years ago

I haven't tried this project yet, but this is a concern for me. Has this been addressed?

RickRockholdMediafour commented 10 years ago

Not to my knowledge, but I haven't checked recent code. In my project, I really only need the ScopedKey class, which doesn't actually use JSON at all, so I made a library that only includes the source files necessary for this class. I might need the other classes as our project grows, though...

Thanks, Rick

Rick Rockhold http://www.mediafour.com www.mediafour.com

On Mon, Jun 9, 2014 at 10:27 AM, Caleb Anderson notifications@github.com wrote:

I haven't tried this project yet, but this is a concern for me. Has this been addressed?

— Reply to this email directly or view it on GitHub https://github.com/keenlabs/keen-sdk-net/issues/2#issuecomment-45503555.

dkador commented 10 years ago

Does this link help? http://stackoverflow.com/questions/17180268/warning-all-projects-referencing-myproject-csproj-must-install-nuget-package-m

I believe the workaround for now is to disable those warnings. Does that work for you?

RobotCaleb commented 10 years ago

I don't like disabling warnings. I'm not familiar with BCL. What does it provide that is needed?

RickRockholdMediafour commented 10 years ago

Daniel,

Yes, that seems to help as a workaround, although I can’t justify using it in production code…manually editing VS project files has caused problems in the past. I’ll just make do with my partial compile of the library for now.

I’d still like to put in my vote for removing the dependency—MS BCL library can be a real pain, and I try to avoid libraries that use it. It causes problems like this because unlike virtually every other .NET library, it wants to participate in the compilation process. Even though we do our best to obtain good code coverage in our tests, making a change to the compilation of our project makes me nervous, especially when the same results can be achieved without leaning on BCL.

Thanks for looking into it! Rick

On Jun 9, 2014, at 11:45 AM, Daniel Kador notifications@github.com wrote:

Does this link help? http://stackoverflow.com/questions/17180268/warning-all-projects-referencing-myproject-csproj-must-install-nuget-package-m

I believe the workaround for now is to disable those warnings. Does that work for you?

— Reply to this email directly or view it on GitHub.

davidknaack commented 10 years ago

I believe the BCL dependency is required by PCLStorage (used in event caching) and Microsoft HTTP Client Libraries, and also for async support in Visual Studio 2012. I'm not sure if it is feasible to remove it entirely.