Implementing cached dataset querying

[Shalelol]

Changes

• Implementing a way to query the new cached datasets API.
• Adding the user of a Snake Case Contract Resolver for NewtonSoft.Json because the use of the JsonPropertyAttribute can get a bit unwieldy once the data structures get larger and more complex, as they can with the cached datasets.

Comments

• I am moving towards strongly typed models, leveraging the convenience of the contract resolver, and trying to work with JToken as infrequently as possible, please let me know if anyone has any issues with this.

• I'm trying to adhere to the naming and code styling convention as much as possible, please do let me know if I stray from that too much.

• I'm quite inexperienced with unit testing, particularly with NUnit, so would love to hear any feedback or advice regarding that.

• I plan to finish work on this pull request mid to late August this year (2017).

Issues addressed

• 92 - Delete Cached Dataset

• 91 - List Cached Dataset Definitions

• 90 - Retrieve Cached Dataset Results

• 89 - Get Cached Dataset Definition

• 88 - Create Cached Dataset

[masojus]

Thanks @Shalelol I will take a look! Meanwhile could you specify which Issues this resolves? Thanks!

[Shalelol]

Hey @masojus I've updated my initial comment to include the issues addressed so far. I also may look into addressing more of the issues related to cached datasets as my requirements grow.

[masojus]

Thank you @Shalelol! And don't worry about the AppVeyor failure. I imagine it's an expected failure I need to deal with but all the tests look to have passed. I presume manual testing went well? Or are there any major corner cases to watch out for?

[Shalelol]

@masojus So far all manual testing is working perfectly. I will inform you if any corner cases pop up.

I'm also still yet to write a unit test for GetDatasetDefinition but will be doing so shortly.

[coveralls]

Coverage decreased (-2.3%) to 55.106% when pulling 6f3a5b403c4d207090b17d5dd59ca757c7d5127a on clickviewapp:cached-datasets into 7f201124217b559026c8db3f07d85b3f7a61546a on keenlabs:master.

[Shalelol]

Hey @masojus, I just want to apologize for the messy state of some of the code. I just realized that I didn't really communicate how WIP this Pull Request is. I had/have every intention of coming back and cleaning everything up, things such as xml comments, moving files out and scoping usings to match the rest of the project. This is still very much an in progress project at the moment as we move all of our querying to cached querying.

I was just putting the WIP PR up nice and early so that it's on your radar =]

Thanks for your comments so far, I will make sure to clean everything up.

[masojus]

@Shalelol No worries. I'm just skimming it anyway, so I'll take a closer look at it later when you've tidied up a bit and think it's ready for prime time. 👍 Thanks!

[tbarn]

@Shalelol just wanted to say, thanks for working on this! We really appreciate it.

[coveralls]

Coverage decreased (-2.3%) to 55.106% when pulling e0a6ebbe5f4ca410aede12b356c16251633a9788 on clickviewapp:cached-datasets into 7f201124217b559026c8db3f07d85b3f7a61546a on keenlabs:master.

[masojus]

We don't have the Travis config merged into master yet, so I wouldn't worry too much about that one.

[Shalelol]

Just updated the opening comment with issues. I plan to implement #88, #91 and #92 for completeness.

[coveralls]

Coverage decreased (-6.01%) to 51.439% when pulling dae4202d0254649bb4d7482fb47e70b20210bf69 on clickviewapp:cached-datasets into 7f201124217b559026c8db3f07d85b3f7a61546a on keenlabs:master.

[coveralls]

Coverage decreased (-6.4%) to 51.085% when pulling 4b42fce0b52993330d5d5427c030aaeddc9c482d on clickviewapp:cached-datasets into 7f201124217b559026c8db3f07d85b3f7a61546a on keenlabs:master.

[coveralls]

Coverage decreased (-6.3%) to 51.138% when pulling 891b1aeaedabb9d9d288676d8570150b28cf918d on clickviewapp:cached-datasets into 7f201124217b559026c8db3f07d85b3f7a61546a on keenlabs:master.

[coveralls]

Coverage decreased (-6.2%) to 51.301% when pulling c2602e99a236e0190fa16d3a9126f13df53536b2 on clickviewapp:cached-datasets into 7f201124217b559026c8db3f07d85b3f7a61546a on keenlabs:master.

[coveralls]

Coverage decreased (-5.9%) to 51.539% when pulling 3fcb789ddd383b4298a9b593623cdabf72689355 on clickviewapp:cached-datasets into 7f201124217b559026c8db3f07d85b3f7a61546a on keenlabs:master.

[Shalelol]

Coveralls likes to point out when you've been bad, but not when you're trying to improve the coverage 😞.

[baumatron]

I think It should hand out gold stars and/or free beers for increased coverage ⭐️ 🍻.

[coveralls]

Coverage decreased (-1.1%) to 56.346% when pulling ff25092ebdbbaccb0ecb786fe5a7d986f83b9a2e on clickviewapp:cached-datasets into 72457ff57503bba4395a89f5d445b26c6065e485 on keenlabs:master.

[coveralls]

Coverage increased (+2.3%) to 59.724% when pulling 7674dc44563e51d0a0a82cecc9329c0a5ecf77a7 on clickviewapp:cached-datasets into 72457ff57503bba4395a89f5d445b26c6065e485 on keenlabs:master.

[coveralls]

Coverage increased (+3.9%) to 61.314% when pulling f90189c67817684450ce7cac5decd8ebaffa44c7 on clickviewapp:cached-datasets into 72457ff57503bba4395a89f5d445b26c6065e485 on keenlabs:master.

[coveralls]

Coverage increased (+3.9%) to 61.314% when pulling 16b6f51707a99d7c3d8da811e2e4b7cadc2621bf on clickviewapp:cached-datasets into 72457ff57503bba4395a89f5d445b26c6065e485 on keenlabs:master.

[Shalelol]

Hey @masojus. I've finished implementing all the Cached Dataset issues, and I've brought the coverage of Keen.Core.Dataset up to 91%. I've also gone through and added XML comments to everything that is public facing.

Could you please give this another review when you have time?

Thanks 😃.

[masojus]

Thank you! We'll get some eyes on this as soon as possible.

[masojus]

Sorry for the delay here. We're going to be merging the dotnetsummer branch shortly and will address this after that so as to also port it to .NET Standard 2.0 while we're at it.

[masojus]

Hello @Shalelol, we've now merged the big chunk of work we wanted to get into master before taking this PR on. Could you merge from master and update the PR? If you need help with that we can pitch in, but then we could work on getting this PR in. Thanks!

[masojus]

I created branch jm_UpdateCachedDatasetsBranch to get this up to date with master and continue the conversation. I'll probably close this PR and we can finish polishing that off in the new PR.

[masojus]

See PR #128 for a continuation of this PR.