keenon / AddBiomechanics

A tool to automatically process and share biomechanics data
https://addbiomechanics.org/
Other
26 stars 5 forks source link

Consistency of "folder" and "dataset" #216

Closed mattpetrucci closed 6 months ago

mattpetrucci commented 7 months ago

Currently, when you create a folder it shows up in the list as a "dataset." We could make these consistent so they are either both folder or both dataset.

AlbertoCasasOrtiz commented 7 months ago

@mattpetrucci @keenon @jenhicks Hi everyone. Which one should we use, folder or dataset? Once we decide I could change it everywhere.

mattpetrucci commented 7 months ago

I would lean towards using dataset, just so its inherently obvious that you may want to aggregate your subjects into a dataset. But I'm open to either

AlbertoCasasOrtiz commented 7 months ago

I agree on dataset too. I think it is more intuitive and aligns better with addbiomechanics mission

mattpetrucci commented 7 months ago

We can split this into a different issue if you prefer, but I also just realized that you aren't able to change dataset or subject names after they are created. We may want to have that option.

AlbertoCasasOrtiz commented 7 months ago

I checked and there is already an issue for changing names of folders and subjects: https://github.com/keenon/AddBiomechanics/issues/92

mattpetrucci commented 7 months ago

Great, thanks for finding. Is that a difficult change to implement?

AlbertoCasasOrtiz commented 7 months ago

I am not sure, but I think at some point last year we discussed it and it is not easy due to how AWS works? I think @keenon will know better