Since users are not prompted to pass foot body names when not fitting dynamics, the pipeline will use the default foot body names calcn_r and calcn_l. If the user is using a model with differing foot body names, this will lead to a segfault within SubjectOnDiskTrialPass::computeValuesFromForcePlates (retrieved foot bodies are nullptr).
Aside from some fixes on the nimblephysics side, we need to decide how to handle this user case. Should we even be calling SubjectOnDiskTrialPass::computeValuesFromForcePlates after running the kinematics fitter? If so, how do we obtain the foot body names? Should we always ask the user for foot body names, regardless of fitting dynamics or not?
Even when only running the kinematics fitter of the AddBiomechanics pipeline, the foot bodies are used to compute some values when writing out results. This happens in a call to
SubjectOnDiskTrialPass::computeValuesFromForcePlateswhen writing out B3D files.Since users are not prompted to pass foot body names when not fitting dynamics, the pipeline will use the default foot body names
calcn_randcalcn_l. If the user is using a model with differing foot body names, this will lead to a segfault withinSubjectOnDiskTrialPass::computeValuesFromForcePlates(retrieved foot bodies arenullptr).Aside from some fixes on the
nimblephysicsside, we need to decide how to handle this user case. Should we even be callingSubjectOnDiskTrialPass::computeValuesFromForcePlatesafter running the kinematics fitter? If so, how do we obtain the foot body names? Should we always ask the user for foot body names, regardless of fitting dynamics or not?