keenon / AddBiomechanics

A tool to automatically process and share biomechanics data
https://addbiomechanics.org/
Other
26 stars 5 forks source link

Automatically generated "has_grf" label #240

Open TheOne-1 opened 5 months ago

TheOne-1 commented 5 months ago

For some trials, fames with valid GRF are labeled as missing GRF.

Here are two examples: https://dev.addbiomechanics.org/data/e013a4d2-683d-48b9-bfe5-83a0305caf87/Carter2023_Formatted_No_Arm/P007_split1/trials/flatrun_fast_1/segment_5/

https://dev.addbiomechanics.org/data/e013a4d2-683d-48b9-bfe5-83a0305caf87/Tan2022_Formatted_No_Arm/02/trials/baseline/segment_1/

nickbianco commented 5 months ago

The ground reaction detection heuristics are probably to blame here. It's been a while since I've look into these, and I'm usually hesitant to make changes since they're pretty fragile. But if this a persistent issue we could look into revamping them.