keenon / AddBiomechanics

A tool to automatically process and share biomechanics data
https://addbiomechanics.org/
Other
26 stars 5 forks source link

Add more granularity for warnings in the backend #241

Open AlbertoCasasOrtiz opened 5 months ago

AlbertoCasasOrtiz commented 5 months ago

In the current version, we only have one flag indicating if there are warnings or not for a specific trial, but we are not propagating the actual warnings to the frontend. We should try to propagate them using the _results.json file.

https://github.com/keenon/AddBiomechanics/blob/78615e4b77154a23e342522787766d9244ad69b0/server/engine/src/trial.py#L485

Warnings seem to come from nimblephysics, from this class.

In the class, there are two vectors for warnings and info. We should check if they are being used right now, and in case they are not being used, maybe use them to better store and propagate warnings and info messages.