search

keenon / nimblephysics

Nimble: Physics Engine for Biomechanics and Deep Learning
http://www.nimblephysics.org
Other
403 stars 44 forks source link

Fix for `DynamicsFitter` aborting too early during residual moment fitting step #107

Closed nickbianco closed 1 year ago

nickbianco commented 1 year ago

Addresses #106.

The criteria for aborting the residual moment fitting step was too strict (i.e., it could abort even if the residuals were very small, if there was a large enough percent increase in the residuals). This fix makes these criteria less stringent, but we can still abort the problem if it is obviously blowing up.

nickbianco commented 1 year ago

@keenon made this PR for tracking purposes. Going to merge to get this fix in.