keenon / nimblephysics

Nimble: Physics Engine for Biomechanics and Deep Learning
http://www.nimblephysics.org
Other
403 stars 44 forks source link

Error if the unit of CoP is mm in grf.mot #130

Open TheOne-1 opened 1 year ago

TheOne-1 commented 1 year ago

https://github.com/keenon/nimblephysics/blob/bf5c5a174ef236c1a2fe3db9a810bdb87f403d53/dart/biomechanics/DynamicsFitter.cpp#L9656-L9661 Close this issue if I'm wrong but my understanding of DynamicFitter is that it can adapt to .mot files with different CoP units (e.g., mm or m). However, I encountered "Marking trial 0, timestep xxx as probably missing GRF, due to contact heuristic" warning by using mm as CoP unit, probably because the above "padding" is in m.

nickbianco commented 1 year ago

@TheOne-1 I believe COP information is converted to meters before this step, although after checking OpenSimParser::loadGRF, I wasn't able to confirm this.

@keenon, do you know if we convert to meters somewhere else?