search

keenon / nimblephysics

Nimble: Physics Engine for Biomechanics and Deep Learning
http://www.nimblephysics.org
Other
403 stars 44 forks source link

skel returned by readSkel function does not have body scales #211

Open TheOne-1 opened 5 months ago

TheOne-1 commented 5 months ago

readSkel function sets gravity vector. However, it does not set body scales, which are needed for forward kinematics and my loss functions.

Based on Nimble wiki, readSkel is used for result visualization purposes, so scales should be included.

TheOne-1 commented 5 months ago

Talked to Keenon about this and he says the scales are embedded into the mesh geometry.

nickbianco commented 4 months ago

Talked to Keenon about this and he says the scales are embedded into the mesh geometry.

@TheOne-1 can this be closed then?

TheOne-1 commented 4 months ago

Probably not. I don't need scales for now but others might need them. It would be good to infer scales from meshes and include them in the readSkel.