search

keep-network / keep-common

Common libraries and tools used across Keep repositories
MIT License
5 stars 14 forks source link

Expose checkStoragePermission as a Public Function #77

Closed beaurancourt closed 3 years ago

beaurancourt commented 3 years ago

Having this be public would be broadly useful. See: https://github.com/keep-network/keep-ecdsa/pull/756/files#diff-ca2057cf86a8e1934767fc81dc8dfeb18e843c2bd3d52d99442a248553b36296R26

Tagging @nkuba for review

Shadowfiend commented 3 years ago

Had some light discussion with @beaushinkle on what we really want here, which is to adjust persistence.Handle to provide support for multiple storage areas, some of which need the current/archive/snapshot behavior and some of which just store data normally. For now, we can expose functions like this one, but ideally we'd export a higher-level abstraction and leave these low-level details unexported.

We can explore this further in the future.