search

keep-network / keep-common

Common libraries and tools used across Keep repositories
MIT License
5 stars 14 forks source link

Added missing space in the transaction submission message #78

Closed nkuba closed 3 years ago

nkuba commented 3 years ago

The logged message didn't contain a space between method name and params (resulted in e.g. submitPublicKeyparams:). In this PR we added a space.

Sample message that used to be logged:

2021-06-01T16:03:57.284+0200    DEBUG   keep-contract-BondedECDSAKeep   submitting transaction submitPublicKeyparams: [49 219 244 160 164 177 151 147 225 55 231 231 13 50 114 78 174 57 148 142 172 39 121 149 129 195 214 68 39 231 163 221 134 243 60 24 160 47 117 146 221 39 240 12 61 223 158 199 217 56 123 186 74 106 19 207 204 16 203 241 234 62 64 254]

The second commit we included in this PR is a simplification. As Hash type implements theString() function we can use %s in logger message format to log the value as hexadecimal string.

beaurancourt commented 3 years ago

Seems like we're getting unrelated celo failures @_@