liz-shinn
commented
3 years ago Thanks for the feedback @saltypalo ! 🎊 A few initial comments:
-
Wallet connection banner: this is an interesting idea. I like the additional visual cue of the icon of the wallet connection type. I've got vector icons for all of those so no need to prepare vectors, but ty
-
Language tumblr/ internationalization: good point, this is on the roadmap but not sure of timeline for this yet.
-
Links at bottom of page: 100% agree that Discord should be linked here. This is being addressed here with the updates to the footer: https://github.com/keep-network/keep-core/issues/2001 Fork button is an interesting idea... 🤔 Agreed that team / advisors / etc don't make much sense in context here, have removed those in favor of a general link to the Keep website
-
Random beacon rewards: yup, got this issue logged here: https://github.com/keep-network/keep-core/pull/2050 That's a good point about the accumulating sticker color, since it's similar to a pending status (which is indicated by a yellow)
-
Left side of token dashboard goes over bottom black part at the Random Beacon Rewards page. <- I'll log this as a bug
-
for Top-ups "?" tip would be helpful at "Delegate Tokens From:" page. I actually don't know what this is intended for, so I'm curious too Noted. This section is meant to show a log of KEEP that's been added to an existing KEEP delegation (a "top up")
-
Contrast/intensity on unavailable buttons Yup, one thing that's come out of the creation of the Community Design System is addressing accessibility of the colors and contrast issues. The disabled state color scheme could use revisiting to make sure it's actually visible.
saltypalo
Below you can find my User Review of test tokenDashboard (which I believe will be almost identical with mainnet?) Keep in mind, that 1) I'm not a professional designer, so this is all from regular user POV. 2) I tried to glance quickly through issues that are already present in this branch but may have missed or forgot that I've seen some of them and this would be the reason why I added it in my review. Tried to submit it today in the morning (you can see time in one of the screenshots, I'm in UTC+3), but somehow wasn't successful. Hope that it will still be helpful
Wallet connection banner There's no issue with the current one, just thought about improving it a bit. Below you can find my suggested version. If you like it, please let me know and I could prepare Vector version and for every wallet too(Ledger, Trezor, etc.)
Language tumbler I know, that is a big thing and need lots of prework and translation check, but it would be much easier for other folks to use token dashboard in their native language. Luckily we have enough people willing to submit translations.
Signing in Can confirm that I have the same issues as other users (for example @nahuus123): metamask disconnects after refreshing. My environments - MacOS + Chrome browser and Windows 10 + Chrome browser.
Add keep button in "Delegate Tokens From" page Hovering over Add keep button and seeing "why can't I add any more keep" tip would be useful (as a "?", or something like that)
Links at the bottom of the page -Discord button at the bottom of the page is absent, while it is certainly one of the main current communication channels for community -Fork button - needed or not? Or at least quick GitHub link would be definitely useful -Team + Advisors link at the bottom of the page. Is it necessary to have advisors there? If so, why there also no "Our stakers link" which is at the same page with Team and Advisors
Loading time -Slow time of upload mainly for Random Beacon Rewards page - was waiting for a few minutes -Token Overview page -"Delegate Tokens From" page -as for tBTC application page - first (upper) half loads quite quickly, but for bottom half to load you have to wait some time.
Random beacon rewards page issues Random Beacon rewards - overlaying (hovering over text)
"Accumulating sticker" might be colored in a different tone or color (yellow or smth like that as it's in the process) -Left side of token dashboard goes over bottom black part at the Random Beacon Rewards page.
Other suggestions -Possibility to add another color from the Keep palette (might be like with purple one, which is already there)
-"Success!Transaction hash: 0x79cf337d7926225874cd1a71bc457fdf2f1cf86391df437b45e1255f6e0e5a27" - remains there all the time after it happened. Should it be like that?
-Email us / support button below. -- Functional support button which can make a screenshot of the error/bug immediately after you press it and then it's easier for support to sort out the problem
-for Top-ups "?" tip would be helpful at "Delegate Tokens From:" page. I actually don't know what this is intended for, so I'm curious too
-Contrast/intensity on unavailable buttons - they're borderline not visible. For people with low contrast monitors or weak eye vision this will be just like plain white background. This will improve accessibility if you could add a bit more of contrast for these buttons. Please see examples below
Example how it may be done so we could still see that it's unavailable but still there
-"A Thesis* Build © 2020 Keep, SEZC. All Rights Reserved." - also borderline not visible
-Privacy Policy, Terms of Use and Playing for Keeps terms - is this necessary or not? Since I've seen this on main Keep Network site and was wondering whether it should be at Token dashboard too
For the moment that's everything I found. Also today in the morning I asked my designer friend (who is not in Crypto) to check out this dashboard and overall he was very positive about it. For him it looks like everything is at the right place and dashboard is user-friendly and informative. So, really good job, Keep team!