keep-network / keep-core

The smart contracts and reference client behind the Keep network
https://keep.network
MIT License
118 stars 73 forks source link

Remove global electrum workarounds made for electrs #3619

Open nkuba opened 1 year ago

nkuba commented 1 year ago

To support Electrs we had to add couple of workarounds in GetTransaction and GetTransactionConfirmations methods due to https://github.com/Blockstream/electrs/pull/36.

Example: https://github.com/keep-network/keep-core/commit/3db34f083c2c9e3c5b85e203abe830b57e807012

Those workarounds are not necessary for other servers we integrate with like ElectrumX and Fulcrum. Having the workarounds generally applied makes the flow complicated and complicated.

We should use the workaround only for Electrs and use the functions exposed by other servers directly.