keep-network / keep-core

The smart contracts and reference client behind the Keep network
https://keep.network
MIT License
122 stars 75 forks source link

Add 20% to the original gas estimate for the sweep proposal #3638

Closed pdyraga closed 1 year ago

pdyraga commented 1 year ago

Closes #3610

The original estimate for this contract call is too low and the call fails on reimbursing the submitter. Here we add a 20% margin to overcome the gas problem.

Examples of failures: 0x5711df32d785140ca6b5b12c87f818a6c5d75d10445a12a7d3d75caadb40c0ac 0xf9a8c0b0ecceb673e19eed7af7c9963cdd929468fb3818e9a8c3b8c59dc6ef85

I stumbled upon this problem when submitting the very first sweep proposal manually, with CLI. I had to apply this change locally for all other sweep proposals I submitted. Then, I stumbled upon it again when using the automated version from #3635 on a fresh branch and again, had to apply this change to successfully submit proposals.