Closed dimpar closed 1 year ago
The code looks good to me but before it is merged we decided to make an experiment with Grafana on how it handles empty query results from Prometheus: most nodes will have the Bitcoin connectivity metric and diagnostics and some nodes (bootstraps) will not.
The code looks good to me but before it is merged we decided to make an experiment with Grafana on how it handles empty query results from Prometheus: most nodes will have the Bitcoin connectivity metric and diagnostics and some nodes (bootstraps) will not.
I've simulated on Testnet Grafana by querying a non-existent metric name. Nothing bad happened, Grafana simply didn't pull it. I've used it along with other metric names that do exist and it also worked. I think we should be fine having the btc metrics and diagnostics available only for some of the nodes.
Refs https://github.com/keep-network/keep-core/issues/3608
btc_connectivity
under the/metrics
. It shows 1 or 0 - connected or notlatest_btc_block_number
/diagnostics
that read the latest Bitcoin blockExample output:
http://192.168.1.8:9601/diagnostics
http://192.168.1.8:9601/metrics