keep-network / keep-core

The smart contracts and reference client behind the Keep network
https://keep.network
MIT License
118 stars 73 forks source link

Package `pkg/maintainer/spv` should not depend on `btcd` directly #3677

Open lukasz-zimnoch opened 1 year ago

lukasz-zimnoch commented 1 year ago

The btcd package is a 3rd party dependency meant to be used only within pkg/bitcoin package which isolates it from the client code. However, pkg/maintainer/spv depends on btcd directly which makes it leak beyond pkg/bitcoin. We should fix that and ensure btcd is not used directly by any other package except pkg/bitcoin.