search

keep-network / keep-core

The smart contracts and reference client behind the Keep network
https://keep.network
MIT License
118 stars 73 forks source link

Improve redemption request proposal event deduplication #3698

Closed pdyraga closed 8 months ago

pdyraga commented 1 year ago

The deduplicator for redemption proposal events takes into account redeemer output script and redemption TX fee:

https://github.com/keep-network/keep-core/blob/c83fc9a6d7b335d9a9fd6a3580c429423f1b03f6/pkg/tbtc/deduplicator.go#L203-L208

If the given redeemer is the only one redeeming for the last few hours and the Bitcoin TX fee estimation did not change, the redemption proposal for the second (valid!) redemption request will be ignored as a duplicate.

One possible option to fix this could be to shorten the caching period for this particular event. There may be better solutions but I can't think of any right now.

erdogan commented 12 months ago

@lukasz-zimnoch, this was opened by Piotr but did not have an owner. Temporarily tagging you here, feel free to reassign or deprioritize if this is not urgent

lukasz-zimnoch commented 8 months ago

No longer relevant due to: https://github.com/keep-network/tbtc-v2/issues/737