search

keep-network / keep-core

The smart contracts and reference client behind the Keep network
https://keep.network
MIT License
118 stars 73 forks source link

Set unmarshallers early during signing #3700

Closed tomaszslabon closed 1 year ago

tomaszslabon commented 1 year ago

Refs https://github.com/keep-network/keep-core/issues/3611.

This PR handles problems with unmarshallers not found errors during signing:

eep-libp2p  libp2p/channel.go:286   couldn't find unmarshaler for type [protocol_announcer/announcement_message]
keep-libp2p libp2p/channel.go:286   couldn't find unmarshaler for type [tbtc/signing_done_message]

The solution is is to register the marshaller for those messages early, before the signing process begins.

dimpar commented 1 year ago

I run the clients just fine, but I don't think I can hit the early signing stage before the sweep proposal on my local. System tests passed. Code looks good to me as well. Leaving the final approval to @lukasz-zimnoch or @pdyraga since they are more familiar with the flow.

dimpar commented 1 year ago

It was decided that the full flow will be validated on the testnet with the keep clients that have this change. Otherwise, it is very tricky to hit the early signing stage before the sweep on the local env.