search

keep-network / keep-core

The smart contracts and reference client behind the Keep network
https://keep.network
MIT License
113 stars 72 forks source link

Harden moving funds against edge cases #3813

Closed tomaszslabon closed 2 months ago

tomaszslabon commented 2 months ago

Refs https://github.com/keep-network/keep-core/issues/3812.

This PR modifies the safety margin validation process used during moving funds. It is possible that a wallet may receive deposits just before it changes states to MovingFunds. It is also possible another wallets in MovingFunds state may commit to transfer their funds to it.
To avoid a situation where a wallet ends up with additional funds after it has already moved their own funds we must apply a safety margin. In https://github.com/keep-network/keep-core/pull/3810 we already added a 24-hour safety margin. In this PR we add a longer 14-days safety margin when the wallet is a target of a moving funds process from another wallet. We also make sure the calculated safety margin is not greater than half of the movingFundsTimeout, so that a wallet has enough time to finish their moving funds process.