search

keep-network / keep-core

The smart contracts and reference client behind the Keep network
https://keep.network
MIT License
117 stars 73 forks source link

Peer identity uniqueness #383

Open pdyraga opened 5 years ago

pdyraga commented 5 years ago

Should we enforce peer identity uniqueness? Having two or more peers in the network with the same ID may result in problems in receiving messages by those peers and finally lead to slashing.

mhluongo commented 4 years ago

If we enforce uniqueness naively, client restarts might have issues- eg a new client instance won't be able to connect to the network for some period, even if the old one is down, as routing propagates- which could also lead to slashing.

Would it make sense for only the impacted peers to respond to the situation? Eg client A and client A' with peer ID B detect that they have a duplicate peer ID, and the older client panics? Or maybe both log the issue, and we leave it to operators to resolve?