keep-network / local-setup

Allow to easily set up tBTC and Keep locally for development and test purposes.
MIT License
8 stars 16 forks source link

Checkout specific SHA of cov-pools during installation of repositories #130

Closed michalinacienciala closed 2 years ago

michalinacienciala commented 2 years ago

We need to checkout coverage-pools at 6a9b084, as after that commit we introduced in the the Asset Pool contract a call to a delegate function which is not present in the KeepToken contract used during AssetPool's deployment script. Using latest code from main was causing error in the E2E tests on local env., at the stage of running 05_deploy_asset_pool.ts script during installation of coverage-pools. Error was misleadingly suggesting problems with gas estimation (cannot estimate gas; transaction may fail or may require manual gas limit).

More details about the root cause:

Workflow with E2E tests run on the feature branch: https://github.com/keep-network/local-setup/actions/runs/1817475780

Refs: https://github.com/keep-network/keep-core/pull/2818