search

keep-network / local-setup

Allow to easily set up tBTC and Keep locally for development and test purposes.
MIT License
8 stars 16 forks source link

Don't use unauthenticated git protocol #136

Closed michalinacienciala closed 2 years ago

michalinacienciala commented 2 years ago

The tbtc.js package contains a dependency to @summa-tx/relay-sol@2.0.2 package, which downloads one of its sub-dependencies via unathenticated git:// protocol. That protocol is no longer supported by GitHub. This means that in certain situations installation of the package or update of its dependencies using NPM may result in The unauthenticated git protocol on port 9418 is no longer supported error or errors like ENOENT: no such file or directory, open '/home/runner/work/local-setup/local-setup/e2e/node_modules/.staging/...'. That what was happening during execution of e2e-local.yml and `e2e-testnet.yml. workflows.

As a workaround, we're adding to workflows a step which configures Git to use https:// protocol instead of git:// when downloading files.

More info: https://github.blog/2021-09-01-improving-git-protocol-security-github/.

michalinacienciala commented 2 years ago

The modified workflows were tested here: E2E local - passes E2E testnet - fails, but on later stage than before and due to different reason