search

keep-network / local-setup

Allow to easily set up tBTC and Keep locally for development and test purposes.
MIT License
8 stars 16 forks source link

Remove trailingComma: "all" from the prettier config #83

Closed beaurancourt closed 3 years ago

beaurancourt commented 3 years ago

Our other projects don't include trailingComma: "all" in their prettier configs, so we remove it here and then re-run the prettier command.

This was the bottom of a rabbit hole, but I wanted to change keep-ecdsa/solidity/scripts/lcl-client-config.js. Changing that triggered the javascript linting job, which showed that there were a bunch of missing commas and wouldn't let me commit. I opened a separate PR to lint the ecdsa client: https://github.com/keep-network/keep-ecdsa/pull/779, but that PR didn't match with the lint reports from the linting job.

After a significant amount of debugging, it turns out that the linting job in github had a clean .prettierrc, and my development machine's ecdsa lint configuration was inheriting from this local-setup's config. The near-term solution is to standardize local-setup's config. Longer term (and in a separate PR) is to find a way to point all of the projects configuration at a single file.

Tagging @Shadowfiend for review

beaurancourt commented 3 years ago

@Shadowfiend anything else you want to see here?

Shadowfiend commented 3 years ago

Let's add a .git-blame-ignore-revs for this formatting commit and then I think we're good here.