search

keep-network / tbtc-dapp

Deposit BTC and redeem TBTC
http://dapp.test.tbtc.network/
MIT License
33 stars 31 forks source link

Lot size selector #287

Closed ironng closed 4 years ago

ironng commented 4 years ago

Updates the first step in the deposit flow to allow the user to select a lot size for the new deposit. This PR also adds a new format utility formatSatsToBtc and new breakpoints for the app width's max size, so that the lot size options can appear on one line on larger screens (previously the max width was 768px).

Screenshots ![FireShot Capture 073 - tBTC - localhost](https://user-images.githubusercontent.com/1986137/88114169-22da7180-cb68-11ea-88e0-b6f4e5cea8de.png) ![FireShot Capture 074 - tBTC - localhost](https://user-images.githubusercontent.com/1986137/88114180-2837bc00-cb68-11ea-9dc5-ded3ce62cd8b.png) ![FireShot Capture 078 - tBTC - localhost](https://user-images.githubusercontent.com/1986137/88116206-ec532580-cb6c-11ea-9fc0-b101cf6112eb.png)

Closes #255

danimesq commented 4 years ago

Why not also adding lot sizes of 2, 3, and 5 BTC? It will be useful not only for testing but also for mainnet, as there will be high burdens of minting tBTC (ETH fees) and bigger lots will be most used.

mhluongo commented 4 years ago

Lot sizes are governable, not decided in the dApp- this just reads them from contract state.

If you want to discuss a protocol change, you can open up a new issue on tbtc @daniellmesquita

ironng commented 4 years ago

@Shadowfiend This is ready for re-review when you get a chance :)

danimesq commented 4 years ago

Is it already live in the test dapp?