keep-network / tbtc-dapp

Deposit BTC and redeem TBTC
http://dapp.test.tbtc.network/
MIT License
33 stars 31 forks source link

Redeeming tBTC from a Non Controlled 3rd Party Wallet creates "Redemption complete" Message and a faulty transaction #300

Open ramaruro opened 4 years ago

ramaruro commented 4 years ago

Description:

I tried to Redeem a Non owned tBTC token (owned by another Wallet). I got a succesful message for the redemption, and then an empty transaction. When I go back in the browser I see the correct message that I don't own this deposit:

Steps to reproduce the behavior:

  1. Go to 'https://dapp.test.tbtc.network/redeem'
  2. Enter TDT ID: 0xc9a49ebe55b6f6777b2ddeafb18c27445f4ac402
  3. Enter Bitcoin Address: 2N9B1coVZKgMUewuxLpw2CoEpLj8hUUoYet
  4. Click Redeem
  5. It jumps straight to Step 6/6 and Says "Redemption Complete", as if it was succesful
  6. If you go back in the browser it goes to Step 2/6 and says the correct message: "Redemption is currently only supported for deposits owned by this account (0x200f0AbEAF597351860cb9B1aBf6Bb685f1CB390) or the tBTC Vending Machine (0x28C04f58C9dDe630D5d33773eBFF4c8FA443BBD5). This deposit is owned by 0xACbB1852Cee7e31EC1421af08d121063f7Cf6840." https://dapp.test.tbtc.network/deposit/0x13f169ae324614bd898e0edd50a1180942c7428d/redemption/congratulations

Expected behavior:

I should not get the "Valid Redemption" Message, but the Step 2/6 Correct message: "Redemption is currently only supported for deposits owned by this account (0x200f0AbEAF597351860cb9B1aBf6Bb685f1CB390) or the tBTC Vending Machine (0x28C04f58C9dDe630D5d33773eBFF4c8FA443BBD5). This deposit is owned by 0xACbB1852Cee7e31EC1421af08d121063f7Cf6840." https://dapp.test.tbtc.network/deposit/0x13f169ae324614bd898e0edd50a1180942c7428d/redemption/congratulations

Environment details:

OS: Windows 10 Pro, Version 1909, build 18363.900, 64 bit OS
Web Browser: Google Chrome, Version 83.0.4103.116 (Official Build) (64-bit)
Wallet: Metamask (Chrome extension), Version 7.7.9

Screenshots

image image image image