search

keep-network / tbtc-dapp

Deposit BTC and redeem TBTC
http://dapp.test.tbtc.network/
MIT License
33 stars 31 forks source link

Minting: dApp does not catch speeding up transactions on step 1 of minting tBTC #375

Open suprnrdy opened 4 years ago

suprnrdy commented 4 years ago

Description:

The dApp does not catch the new transaction when speeding up in MetaMask. The page does not progress to step 2 or move to the URL of the deposit contract address. When refreshing the page there is no contract address to refresh to and the minter is brought back to step 1 to create a new deposit.

Steps to reproduce the behavior:

  1. Go to https://dapp.tbtc.network/deposit
  2. Connect to MetaMask wallet
  3. Select your BTC lot size
  4. Select 'Create Address'
  5. Sign the transaction
  6. Click on MetaMask and speed up transaction

Expected behavior:

When the transaction completes, the page should progress to step 2 and request transaction approval to get public key.

Environment details:

OS: OS X Mojave Web Browser: Brave Version 1.14.84 Chromium: 85.0.4183.121 (Official Build) (64-bit) Wallet: Metamask (Chrome extension), Version 8.0.10

Clearwood commented 3 years ago

canceling the Ethereum tx request on MM to initiate a deposit is not handled, the Error should be caught and probs a notification shown + a Button shown to cancel the process or retry :smile: a similar result is to be expected if MM is connected with a hardware wallet and there is a timeout on the signature