keep-network / tbtc-dapp

Deposit BTC and redeem TBTC
http://dapp.test.tbtc.network/
MIT License
33 stars 31 forks source link

Don't use unauthenticated git protocol #406

Closed michalinacienciala closed 2 years ago

michalinacienciala commented 2 years ago

GitHub is no longer allowing for referencing the dependencies using git:// protocol. Instead we can use git+https://. Without the change, npm install executed in GitHub Actions workflows results with The unauthenticated git protocol on port 9418 is no longer supported. error. More info: https://github.blog/2021-09-01-improving-git-protocol-security-github/.

michalinacienciala commented 2 years ago

Although tbtc-dapp are no longer failing on main (not really sure why), I think we could still introduce this change.

nkuba commented 2 years ago

@michalinacienciala please resolve conflicts.

michalinacienciala commented 2 years ago

@michalinacienciala please resolve conflicts.

@nkuba, resolved