Update factions.go

[adrianvrj]

• [x] issue #217
• [x] follows contribution guide
• [ ] code change includes tests
• [ ] breaking change

[vercel[bot]]

@adrianvrj is attempting to deploy a commit to the keep-starknet-strange Team on Vercel.

A member of the Team first needs to authorize it.

[adrianvrj]

Nice work so far!

will solve your requests asap!

[b-j-roberts]

When using the route, I am getting {"data": null}. So I think there may be something wrong with the query.

You can test the route by starting the app with docker compose. There are details in the readme for that, then doing curl http://localhost:8080/get-faction-members\?factionID\=0

I'd also recommend testing the query with psql so you don't need to restart each time you change the query.

[adrianvrj]

When using the route, I am getting {"data": null}. So I think there may be something wrong with the query.

You can test the route by starting the app with docker compose. There are details in the readme for that, then doing curl http://localhost:8080/get-faction-members\?factionID\=0

I'd also recommend testing the query with psql so you don't need to restart each time you change the query.

That might happen cause users table is empty

Once I added some users manually to the table this is what I get.

[b-j-roberts]

I see, thanks. So the users table won't always have usernames saved for all addresses, so it should be be setup to return an empty string as the username when that's the case. I think using COALESCE for the username should work, but might need to test it out

[adrianvrj]

I see, thanks. So the users table won't always have usernames saved for all addresses, so it should be be setup to return an empty string as the username when that's the case. I think using COALESCE for the username should work, but might need to test it out

Will test it out and lyk

[adrianvrj]

looking like this now without any users in the table!

@b-j-roberts

[b-j-roberts]

Great work, I appreciate the images showing your tests output