keep-starknet-strange / blobstream-starknet

Celestia -> Starknet bridge
https://blobstream-stark.net
MIT License
46 stars 28 forks source link

testing cicd #141

Closed gogo2464 closed 4 months ago

gogo2464 commented 5 months ago

Does not compile on windows. Should I document it?

Reday for a review.

gogo2464 commented 5 months ago

I added a few lines in the readme: https://github.com/keep-starknet-strange/blobstream-starknet/pull/141/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R25

sadly the crlf seems wrong :/

gogo2464 commented 5 months ago

I will look for the git command to remove crlf on windows tommowor.

gogo2464 commented 5 months ago

I did:

git config --global core.autocrlf true
git config --global core.safecrlf false

did not changed nothing. any idea of why?

gogo2464 commented 5 months ago

pleeeeease!!

drspacemn commented 5 months ago

Looks like the README is still edited in the PR. Maybe just create a clean branch and only commit the cicd file?

drspacemn commented 5 months ago

If you need I can create a new PR and just update it with your git action and add you as a reviewer. You will still get paid for the contribution through OnlyDust. lmk

gogo2464 commented 5 months ago

@drspacemn it is ok if you can author me. thanks :)

gogo2464 commented 5 months ago

@drspacemn can I get news please?

gogo2464 commented 4 months ago

@drspacemn I do not have any news. can I continue the PR alone finally then please? I do not want to override your work.

gogo2464 commented 4 months ago

Hello.

As mentionned in private, I would like to know if I can finish it alone or if it will bother you because you could be still busy to do it alone by yourself.

I do not want to overrride your work.

drspacemn commented 4 months ago

Sorry for the delay. I have not done the work so feel free to complete yourself.

gogo2464 commented 4 months ago

I am going to do it.

gogo2464 commented 4 months ago

ready to merge!

drspacemn commented 4 months ago

nice work, thank you!