search

keep-starknet-strange / cairo-lint

A collection of lints to catch common mistakes and improve your Cairo code.
21 stars 35 forks source link

eq_op base implementation #44

Closed Gerson2102 closed 2 months ago

Gerson2102 commented 3 months ago

eq_op base implementation

Is not completed. I still have work to do.

Changes

  1. I added a new file for the eq_op lint.
  2. I created the comparison directory for the eq_op tests.
  3. I added some tests to see the behaviour of the code that I have.
  4. I added the lint in the plugin.rs file.
Gerson2102 commented 3 months ago

I'm stuck trying to figure out how to detect when there is an expression that is calling functions or methods. If you check the tests, there is a test where I'm calling a function in an expression test.get(). For the diagnostic, it should ignore it, but I dont know how to detect something like that in the code, so that there is no diagnostic for these kind of situations. Dont know if somebody can bring some light to this.

Gerson2102 commented 3 months ago

Is weird that my commit says that I changed the bool_comparision tests when I did not. I think I have to be on a commit before right? @0xLucqs

0xLucqs commented 2 months ago

any news ?

Gerson2102 commented 2 months ago

I have not been spending time on it. I dont know if Im gonna be able to solve it.

0xLucqs commented 2 months ago

Ok i'll be able to provide more help next week

Gerson2102 commented 2 months ago

I wanted to solve other issues that I had that I knew that are easier than this one xD