This PR introduces a new lint loop_for_while that detects and suggests replacing unnecessary loop constructs with while loops, improving code clarity and conciseness.
Changes Made ⚡️
Implementation of loop_for_while Lint
Added a new lint in plugin.rs to detect loop constructs that can be replaced by while loops.
Implemented the fix logic in fix.rs, ensuring that the conversion from loop to while preserves the original logic while simplifying the code structure.
Added diagnostic and fix logic in loop_for_while.rs to handle conditions and loop bodies appropriately.
Test Coverage 🥷🏼
Added test cases in test_files/loop_for_while to validate the loop_for_while lint:
Conversion of a simple loop with a comparison condition to a while.
Handling of loop with multiple conditions involving logical operators.
Conversion of a loop with arithmetic conditions.
Ensured that the while loop correctly reflects the logic of the original loop.
Test Results ✅
All tests have passed successfully, confirming that the loop_for_while lint works as intended and improves the readability of the code.
0xLucqs
commented
2 months ago
Summary 📌
This PR closes issue #34
This PR introduces a new lint
loop_for_whilethat detects and suggests replacing unnecessaryloopconstructs withwhileloops, improving code clarity and conciseness.Changes Made ⚡️
Implementation of
loop_for_whileLintplugin.rsto detectloopconstructs that can be replaced bywhileloops.fix.rs, ensuring that the conversion fromlooptowhilepreserves the original logic while simplifying the code structure.loop_for_while.rsto handle conditions and loop bodies appropriately.Test Coverage 🥷🏼
test_files/loop_for_whileto validate theloop_for_whilelint:loopwith a comparison condition to awhile.loopwith multiple conditions involving logical operators.loopwith arithmetic conditions.whileloop correctly reflects the logic of the originalloop.Test Results ✅
All tests have passed successfully, confirming that the
loop_for_whilelint works as intended and improves the readability of the code.