search

keep-starknet-strange / cairo-lint

A collection of lints to catch common mistakes and improve your Cairo code.
21 stars 35 forks source link

feat: Add impossible_comparisons #76 #95

Closed MariangelaNM closed 2 months ago

MariangelaNM commented 2 months ago

Issue 76

Description

  1. Implement is_impossible_double_comparison.
  2. Fix the current implementation.
  3. Add and update tests.
MariangelaNM commented 2 months ago

@0xLucqs

MariangelaNM commented 2 months ago

@0xLucqs , I joined the two logics in is_impossible_double_comparison and added two more examples.

MariangelaNM commented 2 months ago

@0xLucqs ,I updated the initial function to include two additional cases: checking for x > y && x >= y and x <= y && x > y.

MariangelaNM commented 2 months ago

@0xLucqs ,Based on your feedback, I adjusted the logic and placed it in is_redundant_double_comparison

0xLucqs commented 1 month ago

@all-contributors please add @MariangelaNM for code and tests

allcontributors[bot] commented 1 month ago

@0xLucqs

I've put up a pull request to add @MariangelaNM! :tada: