keep-starknet-strange / garaga

State-of-the-art Elliptic Curve operations and SNARKS verification for Cairo & Starknet 🐺.

https://felt.gitbook.io/garaga

MIT License

188 stars 47 forks source link

Poseidon transcript binding #114

Closed StarkFishinator closed 6 months ago

StarkFishinator commented 6 months ago

Pull Request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Testing
[x] Other (please describe): Change a python call to a rust call.

What is the current behavior?

Issue Number: 111 https://github.com/keep-starknet-strange/garaga/issues/111

What is the new behavior?

The hades_permutation function has been called from a rust binding, leading to a 10 times faster calculation time.

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

We ran the two versions (rust and python) 10000 times, and we get the average running time. We see that the rust version is approx 10 time faster.

performance comparison

feltroidprime commented 6 months ago

nice job