keep-starknet-strange / garaga

State-of-the-art Elliptic Curve operations and SNARKS verification for Cairo & Starknet 🐺.
https://felt.gitbook.io/garaga
MIT License
188 stars 47 forks source link

bls: impl G1 generator & fix G2 generator #94

Closed petscheit closed 1 year ago

petscheit commented 1 year ago

While implementing the G1 generator, I discovered that the G2 generator was set without doing cofactor multiplication. To match the BLS12-381 specs, I have updated the G2 generator and implemented the G1 generator.

Pull Request type

What is the current behavior?

The G2 generator point was missing the cofactor multiplication, resulting in a different point being used.

What is the new behavior?

I have updated the G2 generator to match the specs described here

Does this introduce a breaking change?

feltroidprime commented 1 year ago

good