search

keep-starknet-strange / gitcoin-allo-starknet

Gitcoin Allo protocol for Starknet 🐺
MIT License
16 stars 43 forks source link

update profile metadata fn #30

Open Zeegaths opened 5 months ago

Zeegaths commented 5 months ago

Added a function to updateProfileMetadata

kyzan commented 5 months ago

Hey, you might want to use u256 for profile_id.

Zeegaths commented 5 months ago

I did it on the next file

On Tue, 4 Jun 2024, 11:41 am Kartikay Sapra, @.***> wrote:

Hey, you might want to use u256 for profile_id.

— Reply to this email directly, view it on GitHub https://github.com/keep-starknet-strange/gitcoin-allo-starknet/pull/30#issuecomment-2147207618, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZVGWLHD2WF3DGXJHG3R333ZFWKVBAVCNFSM6AAAAABIWQYFSWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBXGIYDONRRHA . You are receiving this because you authored the thread.Message ID: @.*** com>

Zeegaths commented 5 months ago

here: https://github.com/keep-starknet-strange/gitcoin-allo-starknet/pull/30/commits/684033c8202f80cb6b3f4346bf4d8ef15941fb54

On Tue, 4 Jun 2024 at 12:14, Mary Gathoni @.***> wrote:

I did it on the next file

On Tue, 4 Jun 2024, 11:41 am Kartikay Sapra, @.***> wrote:

Hey, you might want to use u256 for profile_id.

— Reply to this email directly, view it on GitHub https://github.com/keep-starknet-strange/gitcoin-allo-starknet/pull/30#issuecomment-2147207618, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZVGWLHD2WF3DGXJHG3R333ZFWKVBAVCNFSM6AAAAABIWQYFSWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBXGIYDONRRHA . You are receiving this because you authored the thread.Message ID: @.*** com>

Zeegaths commented 5 months ago

11

Akashneelesh commented 5 months ago

Hey @Zeegaths , could you please use snake_casing for all the function and variable names.

Zeegaths commented 5 months ago

Done.

On Thu, 6 Jun 2024 at 20:56, Akashneelesh @.***> wrote:

Hey @Zeegaths https://github.com/Zeegaths , could you please use snake_casing for all the function and variable names.

— Reply to this email directly, view it on GitHub https://github.com/keep-starknet-strange/gitcoin-allo-starknet/pull/30#issuecomment-2153304663, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZVGWLH2D3ATKCIBVG4TYATZGC5IJAVCNFSM6AAAAABIWQYFSWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJTGMYDINRWGM . You are receiving this because you were mentioned.Message ID: @.*** com>

Akashneelesh commented 3 months ago

Hey @Zeegaths can you please resolve the merge conflicts