keep-starknet-strange / gitcoin-allo-starknet

Gitcoin Allo protocol for Starknet 🐺
MIT License
16 stars 43 forks source link

is_owner_or_member_of_profile function and is_member_of_profile function #46

Open Manush-2005 opened 2 months ago

Manush-2005 commented 2 months ago

This PR introduces an new function is_owner_or_member_of_profile.

This function will check if the given address is owner or member of the profile.

Fixes #10

The above issue was dependent on another function is_member_of_profile

This function will check if the given address is member of the profile.

So fixed #5 in the process.

Manush-2005 commented 2 months ago

A quick ping on this PR @Akashneelesh

Akashneelesh commented 2 months ago

Please comment under the issue and only pick it up ones you've been assigned to issue. And avoid redundant PR raise for the same issue. Please fix the issue -> do scarb fmt before raising PR and fix the error while trying to do snforge test

Here's where most of the communication is done : https://t.me/starknetindia

Manush-2005 commented 2 months ago

Hey @Akashneelesh , sorry that I didn't communicate well with the fellow contributors. I executed the snforge fmt command as you said.

Manush-2005 commented 2 months ago

Also, snforge tests are failing for me. I think there is an problem with snforge that github workflow is using and the toml file.

Edited: I was trying to test my branch but test are not running.(Using scarb 0.26.3 and snforge 0.23.0)

WhatsApp Image 2024-09-05 at 18 06 42_60e44d35

Akashneelesh commented 1 month ago

Hello @Manush-2005 , looks like the build is failing for some reason. I think its an issue from my side in terms of the CI

Manush-2005 commented 1 month ago

Hey @Akashneelesh , just ran scarb build again to check and the build was successful

Manush-2005 commented 1 month ago

Hey @Akashneelesh , quick ping on this PR.

Manush-2005 commented 3 weeks ago

Hey @Akashneelesh , just a ping on this issue