keep-starknet-strange / gitcoin-allo-starknet

Gitcoin Allo protocol for Starknet 🐺
MIT License
5 stars 17 forks source link

[feat] Implement the functionality of addMembers #7

Open Akashneelesh opened 1 month ago

Akashneelesh commented 1 month ago

Use u256 instead of bytes32 Down below is the function that is to be implemented in the contract but in cairo. https://github.com/allo-protocol/allo-v2/blob/4dd0ea34a504a16ac90e80f49a5570b8be9b30e9/contracts/core/Registry.sol#L289

Resources : https://book.cairo-lang.org/ https://book.cairo-lang.org/ch02-05-control-flow.html?highlight=loop#repetition-with-loops

If you have any doubts over on how to implement something similar to this you can try discovering few cairo code bases such as : Unruggable memecoin : https://github.com/keep-starknet-strange/unruggable.meme/tree/main/packages/contracts/src Blobstream : https://github.com/keep-starknet-strange/blobstream-starknet/tree/main/src

Exclusively for Starknet India team - To onboard new devs from India Estimated Time taken to complete - 2-3 days (Max)

RaveenaBhasin commented 1 month ago

Would like to work on this issue.

Akashneelesh commented 1 month ago

Awesome less goo !!

RaveenaBhasin commented 1 month ago

Attaching the PR for this issue here.