search

keep-starknet-strange / joyboy

Decentralized social built with Nostr and powered by Starknet account abstraction.
https://joyboy.community
MIT License
68 stars 50 forks source link

event escrow for deposit claim and cancel #184

Closed MSghais closed 3 months ago

MSghais commented 3 months ago

Add Events on Escrow for:

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
joyboy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 10:16am
joyboy-webapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 10:16am
ugur-eren commented 3 months ago

Hi @MSghais @maciejka is it possible to have an event for deposit transfers too? For this part:

if (!recipient.is_zero()) {
    let erc20 = IERC20Dispatcher { contract_address: token_address };
    erc20.transfer_from(get_caller_address(), recipient, amount);
    return DepositResult::Transfer(recipient);
}
maciejka commented 3 months ago

Hi @MSghais @maciejka is it possible to have an event for deposit transfers too? For this part:

if (!recipient.is_zero()) {
    let erc20 = IERC20Dispatcher { contract_address: token_address };
    erc20.transfer_from(get_caller_address(), recipient, amount);
    return DepositResult::Transfer(recipient);
}

You are right, added in the comments.