search

keep-starknet-strange / madara-tsukuyomi

Madara Desktop Application
MIT License
20 stars 18 forks source link

feat: Error boundary main #43

Closed 0xGavinOwen closed 9 months ago

0xGavinOwen commented 9 months ago

add error boundary for main process

0xGavinOwen commented 9 months ago

Can you give an example on how to test this? I tried getting the snack bar but wasn't able to reproduce it.

just throw an error in the main process, i just add another commit to throw an error in the main process for demonstration purpose to trigger the snackbar

apoorvsadana commented 9 months ago

Can you give an example on how to test this? I tried getting the snack bar but wasn't able to reproduce it.

just throw an error in the main process, i just add another commit to throw an error in the main process for demonstration purpose to trigger the snackbar

Can you try this - add a return new Error('test') inside the startApp function in madara-app.ts. It should show the snackbar ideally when you try to start the app but it doesn't for me.

0xGavinOwen commented 9 months ago

Can you give an example on how to test this? I tried getting the snack bar but wasn't able to reproduce it.

just throw an error in the main process, i just add another commit to throw an error in the main process for demonstration purpose to trigger the snackbar

Can you try this - add a return new Error('test') inside the startApp function in madara-app.ts. It should show the snackbar ideally when you try to start the app but it doesn't for me.

let me try!