search

keep-starknet-strange / madara

DEPRECATED in favor of https://github.com/madara-alliance/madara
MIT License
532 stars 301 forks source link

dev: scale-codec in blockifier & starknet-api main #1430

Closed tdelabro closed 1 month ago

tdelabro commented 7 months ago

Since https://github.com/keep-starknet-strange/madara/pull/1407 we are able to execute std only code in the runtime. Meaning we are losing the use of our blockifier/starknet-api/cairo-vm forks. Still, we cannot use the libs directly yet, because we need a lot of the types defined there to implement parity-scale-codec::{Encode, Decode}. Those impl are already done in our branches on our forks, but we need them on upstream/main now.

That is the purpose of this issue: open PR to the upstream repos, where you add a parity-scale-codec feature and impl/derive the trait (mostly copy-paste from our branch) on every type defined there.

bidzyyys commented 7 months ago

@tdelabro I can take this one

jerrybaoo commented 5 months ago

I believe this issue is an important prerequisite for upgrading the Cairo and RPC versions. I'd like to know how much work is left to complete. Do we need more people to speed things up? @bidzyyys @tdelabro

tdelabro commented 4 months ago

It most likely will stay in our forks for a bit more. But most types have proper impl at this point

github-actions[bot] commented 3 months ago

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

tdelabro commented 1 month ago

repository archived in favor of https://github.com/madara-alliance/madara