search

keep-starknet-strange / madara

DEPRECATED in favor of https://github.com/madara-alliance/madara
MIT License
531 stars 301 forks source link

added pallet test for InvokeTransaction::V0 #1608

Closed raizo07 closed 3 months ago

raizo07 commented 4 months ago

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

What is the current behavior?

All the transaction tests in are InvokeTransaction::V0

Resolves: missing V0 tests.

What is the new behavior?

Does this introduce a breaking change?

Other information

raizo07 commented 4 months ago

@tdelabro I've opened a PR here, I think you should be able to review here. Thank you.

EvolveArt commented 4 months ago

thanks for this pr @raizo07, I think the issue was about declare v0 tho. Also in this PR you modify an existing test instead of adding a new one. Please also update changelog.

raizo07 commented 4 months ago

thanks for this pr @raizo07, I think the issue was about declare v0 tho. Also in this PR you modify an existing test instead of adding a new one. Please also update changelog.

@EvolveArt Thank you for your comment. But from this link https://github.com/keep-starknet-strange/madara/issues/1603#issuecomment-2112690508 You can see that it is a different task I was asked to work on, of which I added the test. I'm open to further reviews.

tdelabro commented 4 months ago

@raizo07, still working on it?

raizo07 commented 4 months ago

@raizo07, still working on it?

Yes, I'll be sending the PR today.

tdelabro commented 3 months ago

@raizo07 this time the tests don't even compile. run cargo test on you computer